This fixes a bug where we weren't locking the Python env. #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lead to the `Text File Busy` errors, because we were trying to create the virtualenv while another process was running. Instead of this throwing a "version locked" error and retrying, it was just failing because it was never checking for a lock properly.
|
Not sure this is the best approach -- this would give us 3 seperate locking steps on a build (VCS checkout, env setup, and doc building) -- we should probably just use a single lock. The main issue here is that we want to run the VCS checkout updates in a task from webhook endpoints, so it also needs the locking logic. Should be pretty simple to just put a lock=False argument when running it from inside the tasks though. |
|
I think that makes sense. If you have any specific thoughts on a locking refactor, open up an issue to track that. +1 on this for now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lead to the
Text File Busyerrors,because we were trying to create the virtualenv while another process was running.
Instead of this throwing a "version locked" error and retrying,
it was just failing because it was never checking for a lock properly.
Fixes #2229