Serve docs via public/private symlinks, instead of built doc paths. #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new
[private|public]_symlinkroots to serve files from Python.The goal is to reduce the mass of complexity around the logic we have for serving files in Python, and keep all of that in one simple place in the filesystem around symlinks, both for public & private serving, from nginx or Python.
This changes:
core/urlsandcore/viewsinto their own directories.ssl.$PRODUCTION_DOMAIN-- as this was old and unused.*.dev.readthedocs.ioas a local domain for testing subdomains that points at127.0.0.1in public DNSSERVE_DOCSas a setting to determine whether to servepublic,privatedocs