Honor MkDocs configured theme, while keeping 'readthedocs' as the default #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as design decision for now. Though the underlying technical issue might be addressable, we don't see enough support for mkdocs to make this change without degrading user experience for readers. |
|
Going to close this, as I believe we've decided not to allow for this. It would make our support load a lot higher to support multiple themes, and we're already unable to offer good support as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to solve #978, i.e. honoring a MkDocs theme set in
mkdocs.ymlwhile keepingreadthedocsas default theme if none is specified.Let me know if there's any obvious concerns I didn't address, and also whether there's any tests I need to write (I couldn't find any regarding themes).