WIP: Add basic badge support. #2071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
added
the
PR: work in progress
|
Looks great! 😄 |
| url = 'https://img.shields.io/badge/docs-%s-%s.svg?style=%s' % ( | ||
| version.slug.replace('-', '--'), color, style) | ||
| return _badge_return(redirect, url) | ||
| color = 'failing' |
There was a problem hiding this comment.
color looks like a typo to me.
There was a problem hiding this comment.
Yea, the bigger issue here is fixing the SVG template. I just built a very basic example, but need to figure out the SVG part before we can ship it.
ericholscher
removed
the
PR: work in progress
|
This is now fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to hosting badges internally to Read the Docs.
This is a WIP, as the SVG code needs to be fixed. I don't know SVG super well, but we basically just need to fix the template so that it will properly render with variable width text (eg. varying project name length).