-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Make some part of the codebase single source #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm happy to use |
If there is more invasive changes, I can look into six. Especially if str/string/unicode/byte is involved. I'll use six if I feel the necessary changes would be easier with six. |
Should I push more on this branch, want me to actually use six ? Or send smaller changes as separate PRs ? |
I think small PR's like this are best. That way we can get things merged in and they won't rot over time. |
+1 on smaller PRs. Splitting up work between applications, or at least major applications. I'm fine merging this without six for now -- though there are a lot of API driven calls which will be relying on bytestrings. I'll open a ticket to track implementing |
Make some part of the codebase single source
Thanks ! Sorry I've been busy these days, I'll try to send a few small PR to update for python3 compatibility! |
it does not make RTD run completely on Py3 of course, far from it, but it's a first step.