Skip to content

Make some part of the codebase single source #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2015
Merged

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Oct 5, 2015

it does not make RTD run completely on Py3 of course, far from it, but it's a first step.

@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Oct 6, 2015
@agjohnson agjohnson added this to the Python 3 Support milestone Oct 6, 2015
@agjohnson
Copy link
Contributor

I'm happy to use six here as well, if it makes our lives easier.

@Carreau
Copy link
Contributor Author

Carreau commented Oct 6, 2015

I'm happy to use six here as well, if it makes our lives easier.

If there is more invasive changes, I can look into six. Especially if str/string/unicode/byte is involved.
Most compatibility for Py3 might should not need that.

I'll use six if I feel the necessary changes would be easier with six.

@Carreau
Copy link
Contributor Author

Carreau commented Oct 6, 2015

Should I push more on this branch, want me to actually use six ? Or send smaller changes as separate PRs ?

@ericholscher
Copy link
Member

I think small PR's like this are best. That way we can get things merged in and they won't rot over time.

@agjohnson
Copy link
Contributor

+1 on smaller PRs. Splitting up work between applications, or at least major applications.

I'm fine merging this without six for now -- though there are a lot of API driven calls which will be relying on bytestrings. I'll open a ticket to track implementing six.

agjohnson added a commit that referenced this pull request Oct 20, 2015
Make some part of the codebase single source
@agjohnson agjohnson merged commit d41452b into readthedocs:master Oct 20, 2015
@Carreau
Copy link
Contributor Author

Carreau commented Oct 20, 2015

Thanks ! Sorry I've been busy these days, I'll try to send a few small PR to update for python3 compatibility!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants