Clean up logic around how we delete files for deleted projects and inactive versions #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +18,7 @@ | |||
| REPO_TYPE_HG, GITHUB_URL, | |||
| GITHUB_REGEXS, BITBUCKET_URL, | |||
| BITBUCKET_REGEXS) | |||
| from readthedocs.projects.tasks import clear_artifacts | |||
There was a problem hiding this comment.
I think this introduced a cyclic dependency: https://travis-ci.org/rtfd/readthedocs.org/jobs/81886399#L213
You might want to move the import directly into the delete method.
ericholscher
added
the
PR: work in progress
ericholscher
added
PR: ready for review
and removed
PR: work in progress
|
LGTM |
agjohnson
added a commit
that referenced
this pull request
Oct 23, 2015
Clean up logic around how we delete files for deleted projects and inactive versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers actually deleting HTML and other artifacts (pdf, epub, htmlzip) on version & project deletion. This should hopefully fix a lot of cases of projects disappearing.
I would like in the future to capture these 404'ing URLs and attempt to automatically redirect them to canonical versions. Currently we do suggest other versions in the 404, which is probably the best approach, as automatic redirects would be confusing.