Skip to content

Fix links to other versions in mkdocs documentation footer #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2016

Conversation

gregmuellegger
Copy link
Contributor

The problem was that we didn't had access to the correct page name (the relative path to the source file without the .md suffix).

In order for this fix to work mkdocs needs to integrate mkdocs/mkdocs#721 and create a new release.

Blocked by mkdocs/mkdocs#721.
Fixes #1480.

@gregmuellegger gregmuellegger added the Status: blocked Issue is blocked on another issue label Sep 7, 2015
The problem was that we didn't had access to the correct page name (the
relative path to the source file without the .md suffix).

In order for this fix to work mkdocs needs to integrate mkdocs/mkdocs#721 and
create a new release.
@jhamman
Copy link

jhamman commented Oct 2, 2015

@gregmuellegger - mkdocs/mkdocs#721 has been merged. Is there anything keeping this from being merged.

@ericholscher
Copy link
Member

mkdocs needs to make a release with this change in it. We could switch to using the development branch of mkdocs, but that feels like a bad solution.

@jhamman
Copy link

jhamman commented Oct 6, 2015

@ericholscher - I think waiting for the next release of mkdocs makes sense. I'll keep bugging @d0ugal.

@d0ugal
Copy link
Contributor

d0ugal commented Oct 7, 2015

bug away, but I am not going to get to this until next month - getting married makes me super busy

@marcelstoer
Copy link
Contributor

getting married makes me super busy

Congrats!

I am not going to get to this until next month

Hhmm, that would have been last month by now 😉 Would be really happy this issue (and all its dups) would see some progress.

I documented a few more links to verify the PR against in my issue #1884.

@dnrce
Copy link

dnrce commented Jan 25, 2016

@gregmuellegger, is this unblocked by MkDocs 0.15.0?

@dirkrombauts
Copy link

I would like to see this one fixed too! I see there's a new MkDocs release as of a couple of days ago. Maybe that new version helps?

@ericholscher ericholscher added PR: ready for review and removed Status: blocked Issue is blocked on another issue labels Jan 29, 2016
@ericholscher
Copy link
Member

Merging this with the upgraded mkdocs release.

ericholscher added a commit that referenced this pull request Jan 29, 2016
Fix links to other versions in mkdocs documentation footer
@ericholscher ericholscher merged commit d3abbac into master Jan 29, 2016
@agjohnson agjohnson deleted the fix-mkdocs-page-name-issue branch January 30, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation version selection broken with Mkdocs
7 participants