Remove project artifacts from all web servers on project delete #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only did that on the server where the project deletion was triggered. Related #1579.
|
Looks good! We have a handful of projects that should be implemented as broadcast tasks in celery, but it will take some additional work on the operations side to make a broadcast queue work. This is plenty fine for now. |
agjohnson
added a commit
that referenced
this pull request
Aug 26, 2015
Remove project artifacts from all web servers on project delete
|
This is another use case for a quasi-broadcast web queue, like we have for the builders. We are already registering web01/web02/web03 queues with the web celery workers, so it should be quite simple to add the same logic for broadcast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only did that on the server where the project deletion was triggered.
Related #1579.