Fix email notifications on build failures #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def send_notifications(self): | ||
| """Send notifications on build failure | ||
|
|
||
| Don't send failure notices on ``stable`` version builds. |
There was a problem hiding this comment.
Not sure why we decided not to send mail on stable builds -- can you think of a good reason? I think it was to stop spamming, but we should probably enable it.
There was a problem hiding this comment.
Yeah, +1 from me, i don't remember if there was a good reason to not send stable notifies
|
👍 |
ericholscher
added a commit
that referenced
this pull request
Aug 20, 2015
Fix email notifications on build failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the error for global failure into the email. This should only ever be
a line or two, so shouldn't drown out the email