Call python scripts as argument to virtualenv python command #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #994, where the 127 character limit on shebang line lengths was triggering failures of commands inside virtualenvs that had long names or long branch names. This PR adds some path environment variable handling to allow for shorter commands, and makes all python script call wrapped by a call to the virtual env symlinked python binary.
agjohnson
force-pushed
the
build-command-shebang
branch
from
970521b to
23d2859
Compare
agjohnson
added
PR: ready for review
and removed
Status: blocked
| @@ -485,6 +485,14 @@ def single_version_symlink_path(self): | |||
| # | |||
|
|
|||
| def venv_bin(self, version=LATEST, bin='python'): | |||
There was a problem hiding this comment.
Might make sense to just kill the python default here, so that we don't have to pass None everywhere
There was a problem hiding this comment.
I'd prefer this, yes. I didn't want to have to refactor all of the calls, but searching again it looks like there aren't any calling python this way anyways.
|
👍 other than the above nit. |
|
🚢 |
ericholscher
added a commit
that referenced
this pull request
Aug 12, 2015
Call python scripts as argument to virtualenv python command
|
Very concise PR which makes it easy to review. 👍 Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #994, where the 127 character limit on shebang line lengths was
triggering failures of commands inside virtualenvs that had long names or
long branch names. This PR adds some path environment variable handling to
allow for shorter commands, and makes all python script call wrapped by a
call to the virtual env symlinked python binary.
This depends on the pending pull request #1524, for adding docker
containerization and should be rebased after that PR is merged.