Update integrated sphinx_rtd_theme #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we're hoping to stop bundling the theme, and just use the installed version in the venv, which is using the released version. I'll merge this for now, but I think we should def. move away from vendoring it. |
ericholscher
added a commit
that referenced
this pull request
Jul 30, 2015
Update integrated sphinx_rtd_theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the sphinx_rtd_theme with
fab update_theme. This makes it up to date and fixes at least #1497 (modernizr.js was included with a relative path) as it was already fixed in readthedocs/sphinx_rtd_theme@dc0a2a1.Any objections on this?
I only wondered why the
/media/fontdirectory was created. It should have been there already, right?Fixes #1497.