Use ATOMIC_REQUESTS=True to wrap every django request in a database transaction #1400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is a good practice to wrap every request in a transaction. I think we already have lots of places in the codebase that do not explicitly run in a transaction which makes it possible that a requests aborts in the middle (for example in case of an exception) and leaves the DB in an inconsistent state as we might have already processed some, but not all incoming data.
The django documentation states that this might impact performance a bit depending on the used database.
So I'm not sure if that really is the perfect option for readthedocs, but I think we make everything a little more predictable that way :)