Version handling improvements #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
| # self.versions.create(slug='stable', verbose_name='stable', type='branch', active=True, identifier=branch) | ||
| slug=LATEST, verbose_name=LATEST_VERBOSE_NAME, machine=True, type='branch', active=True, identifier=branch) | ||
| # if not self.versions.filter(slug=STABLE).exists(): | ||
| # self.versions.create_stable(type='branch', identifier=branch) |
There was a problem hiding this comment.
Looks like the create_stable isn't used currently?
There was a problem hiding this comment.
It's not in that case. But here: https://github.com/rtfd/readthedocs.org/pull/1354/files#diff-c31d0a7752163caf020c33fb85ba7a96R124
ericholscher
added a commit
that referenced
this pull request
Jun 19, 2015
…ments Version handling improvements
|
🎆 |
gregmuellegger
added a commit
that referenced
this pull request
Jul 31, 2015
It was accidentally removed in 4e7c80e as part of #1354. See: 4e7c80e#diff-d61f6aff9736141f30b581471d5d55ceL515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some improvements that I made while investigating #1052.
The breakdown is:
'stable'and'latest'and use a defined constant instead.create_stable/create_latestmanager methods for easier creation of versions.BetterVersionis a terrible name IMO :) It should more say about what it actually is. I renamed it toVersionIdentifier.