Skip to content

Downgrade to Django 4.2.x due to djstripe #12145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Downgrade to Django 4.2.x due to djstripe #12145

merged 2 commits into from
Apr 30, 2025

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 29, 2025

We need to upgrade djstripe first because the admin is broken otherwise.

See #9706

@humitos
Downgrade to Django 4.2.x due to djstripe
4c1e49a 
We need to upgrade `djstripe` first because the admin is broken otherwise.

See #9706
@humitos humitos requested a review from a team as a code owner April 29, 2025 15:39
@humitos humitos requested a review from ericholscher April 29, 2025 15:39
@humitos
Copy link
Member Author

humitos commented Apr 29, 2025 •
edited
Loading

The pre-commit failing check is not relevant. It's because django-upgrade is targeted to 5.2 -- but the code is 4.2.

stsewd
stsewd approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should downgrade django-upgrade on common I guess.

@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Apr 29, 2025
@humitos humitos mentioned this pull request Apr 29, 2025
Closed
@humitos humitos merged commit ebf6d4d into main Apr 30, 2025
5 of 6 checks passed
@humitos humitos deleted the humitos/downgrade-django-4.2 branch April 30, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@ericholscher ericholscher Awaiting requested review from ericholscher ericholscher is a code owner automatically assigned from readthedocs/backend

Assignees

@humitos humitos

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @stsewd