Upgrade to Django 5.x

[humitos]

Upgrade our code base to Django 5.2

• django-safemigrate had to be upgraded: you will find a lot of changes like Safe.before_deploy -> Safe.before_deploy() (all of them are in this particular commit: 4273e83)
• I had to borrow django.core.files.storage.get_storage_class because it was deleted from Django 5.2
• assertFormError tests were updated to match the new signature
• django-celery-beat and django-storages were upgraded
• Update some old migrations referring to indexes to make them work

Closes #12079
Closes #11505

[humitos]

It seems we are blocked on django-celery-beat still #12079 (comment)

[humitos]

All the tests are passing and the QA that I did locally worked fine.

I'm not sure why the CI checks is failing since I ran pre-commit locally and there is no modifications at all 🤷🏼

[humitos]

I'm not sure if we need to do something else with this, but I don't think so since these are old migrations.

[humitos]

Same here. I had to delete this chunk of code to be able to run the tests. I don't think this will have any impact, tho.

[humitos]

I'm not sure why the CI checks is failing since I ran pre-commit locally and there is no modifications at all 🤷🏼

I reverted that file to what it was before to avoid this issue for now.

[humitos]

This is weird. Removing the migration file makes the migrations to work. However, checks complains about renaming an unnamed index.

Migrations for 'builds':
  readthedocs/builds/migrations/0062_rename_build_version_state_date_success_builds_buil_version_ee7034_idx_and_more.py
    ~ Rename unnamed index for ('version', 'state', 'date', 'success') on build to builds_buil_version_ee7034_idx
    ~ Rename unnamed index for ('version', 'state', 'type') on build to builds_buil_version_dd29f9_idx

[humitos]

I think I was able to make it work... Let see if all the tests pass now.

[stsewd]

Looks good, but we should definitely test more on .com, there we have a couple of deps that are not actively maintained, and may not be compatible with django 5.2..

[humitos]

I opened https://github.com/readthedocs/readthedocs-corporate/pull/1979 with the changes required. I'm going merge this one so we can start test it locally. Remember to rebuild the Docker images.