Add models for GitHub App #12070
Merged
Add models for GitHub App #12070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Mar 26, 2025
| Get or create a GitHub app installation. | ||
|
|
||
| Only the installation_id is unique, the target_id and target_type could change, | ||
| but this should never happen. |
Comment on lines
+247
to
+248
| # When an installation is deleted, we delete all its remote repositories | ||
| # and relations, users will need to manually link the projects to each repository again. |
There was a problem hiding this comment.
Is there a nicer UI we can build for that in the future? Seems like a pretty large downside.
There was a problem hiding this comment.
Maybe something that facilitates re-connection in batch, maybe could be exposed as an API to start. But I only see this a problem for users with lots of repos connected, re-connection is straightforward, just select the repo from the settings and click save.
Yep, the service itself will be in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have only one service with this type of integration, I didn't abstract this as a general attribute (like service_installation or similar), as we don't know if other services will ever bring something similar, and if they do, we don't know how they would implement it.
Extracted from #11942