Skip to content

Use Ruff for linting #12037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Use Ruff for linting #12037

merged 3 commits into from
Mar 11, 2025

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 6, 2025

  • Most of these changes are small lint changes
  • Added safe migrate config to all past migrations
  • Uses ruff config from common

Requires: https://github.com/readthedocs/common/compare/davidfischer/switch-to-ruff


📚 Documentation previews 📚

davidfischer and others added 3 commits March 5, 2025 18:12
- Most of these changes are small lint changes
- Added safe migrate config to all past migrations
- Uses ruff config from common

Requires: https://github.com/readthedocs/common/compare/davidfischer/switch-to-ruff
@davidfischer davidfischer requested review from a team as code owners March 6, 2025 18:20
@davidfischer davidfischer requested review from agjohnson and stsewd March 6, 2025 18:20
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit:

@agjohnson
Copy link
Contributor

I didn't look through the changes here with any depth, there is a lot to review. Just noting that I gave a try to this locally though and it worked great 👍

@davidfischer
Copy link
Contributor Author

There's a lot of files to review but the review actually should go fairly fast since the changes are mostly trivial.

@stsewd stsewd merged commit 2a6af43 into main Mar 11, 2025
9 checks passed
@stsewd stsewd deleted the davidfischer/ruff-for-linting branch March 11, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants