Remote repositories: filter by vcs provider when deleting #12015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
reviewed
Feb 24, 2025
|
I also don't fully understand this change -- is there more context in an issue somewhere? |
|
The current filtering is wrong, we are excluding all remote repositories that belong to a provider, but we aren't filtering by the type of provider. This fixes that by filtering the whole queryset by the type of provider, and then excluding the remote repositories we want to keep. |
ericholscher
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't a problem since we are filtering by account, and the account can only have one type of vcs repositories, but just for consistency.