-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Webhooks: refactor branch/tag building #12014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Extracted from #11942
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some questions since I have some doubts, but I think it's getting close.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks close to me, with just a couple notes. @humitos could also review it again, but I think overall looks good.
Do we plan to build tags directly with this logic? Is there more info on how this changes anything downstream around that?
Only tags/branches that come from a repo webhook
Not sure what downstream refers to here. But all the logic is the same as before, just more exact when selecting the version that corresponds to the branch/tag to build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- would still like to have @humitos give a 👍 to merge tho, since he had some other review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💯
Extracted from #11942