Project: don't depend on the brand name #12008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Feb 19, 2025
| return service_class.allauth_provider.name if service_class else None | ||
| def is_github_project(self): | ||
| from readthedocs.oauth.services import GitHubService | ||
| return self.get_git_service_class(fallback_to_clone_url=True) == GitHubService |
There was a problem hiding this comment.
This will be in [GitHubService, GitHubAppService] with #11942
humitos
approved these changes
Feb 19, 2025
| @@ -1055,10 +1055,24 @@ def get_git_service_class(self, fallback_to_clone_url=False): | |||
| return service_cls | |||
|
|
|||
| @property | |||
| def git_provider_name(self): | |||
There was a problem hiding this comment.
Have you grepped all the repositories to check if we are using it in other places? Just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/readthedocs/readthedocs.org/pull/11983/files/8e6caa3e6157a0230c0989784e8a421cacd7f7bd#r1953455261