Skip to content

Show slug on AddonsConfigAdmin #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Show slug on AddonsConfigAdmin #11974

merged 2 commits into from
Feb 4, 2025

Conversation

ericholscher
Copy link
Member

This is useful for Business where we have a lot of common names

This is useful for Business where we have a lot of common names
@ericholscher ericholscher requested a review from a team as a code owner February 4, 2025 19:13
@ericholscher ericholscher requested a review from stsewd February 4, 2025 19:13
@@ -472,7 +472,7 @@ class EnvironmentVariableAdmin(admin.ModelAdmin):
class AddonsConfigAdmin(admin.ModelAdmin):
model = AddonsConfig
raw_id_fields = ("project", "options_base_version")
list_display = ("project", "enabled")
list_display = ("project", "slug", "enabled")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be project__slug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, yea 🙃

@ericholscher ericholscher merged commit 9b1e784 into main Feb 4, 2025
6 of 7 checks passed
@ericholscher ericholscher deleted the slug-admin branch February 4, 2025 23:20
@humitos
Copy link
Member

humitos commented Feb 5, 2025

It seems this PR broke the checks:

ERRORS:
<class 'readthedocs.projects.admin.AddonsConfigAdmin'>: (admin.E108) The value of 'list_display[1]' refers to 'project__slug', which is not a callable, an attribute of 'AddonsConfigAdmin', or an attribute or method on 'projects.AddonsConfig'.

ericholscher added a commit that referenced this pull request Feb 5, 2025
This reverts commit 9b1e784.

Not sure why this broke..
ericholscher added a commit that referenced this pull request Feb 5, 2025
This reverts commit 9b1e784.

Not sure why this broke..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants