Skip to content

Remove yamale #11855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove yamale #11855

merged 1 commit into from
Dec 13, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 13, 2024

Closes #8549

@stsewd stsewd requested a review from a team as a code owner December 13, 2024 15:27
@stsewd stsewd requested a review from ericholscher December 13, 2024 15:27
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the original concept here was to replace this with jsonschema -- is that already done, or are we replacing this with pydantic?

@stsewd
Copy link
Member Author

stsewd commented Dec 13, 2024

It seems like the original concept here was to replace this with jsonschema -- is that already done, or are we replacing this with pydantic?

Pydantic is a better choice, it also supports generating a json schema from the classes :) (hopefully we can use it without any manual changes).

@stsewd stsewd merged commit a8507ee into main Dec 13, 2024
6 checks passed
@stsewd stsewd deleted the remove-yamale branch December 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace yamale with python implementation of jsonschema
2 participants