Skip to content

Build: remove conda_append_core_requirements feature flag #11847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 23, 2024
Merged

Build: remove conda_append_core_requirements feature flag #11847

merged 4 commits into from
Dec 23, 2024
+30 −91

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 11, 2024

We have had this flag set for a while now.

@stsewd stsewd marked this pull request as ready for review December 12, 2024 16:39
@stsewd stsewd requested a review from a team as a code owner December 12, 2024 16:39
@stsewd stsewd requested a review from humitos December 12, 2024 16:39
humitos
humitos approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. However, we should eventually remove this magic and avoid modifying the Conda environment at all. This work is outside the scope of this PR, tho 👍🏼

@stsewd stsewd merged commit ac87f67 into main Dec 23, 2024
6 checks passed
@stsewd stsewd deleted the remove-conda-ff branch December 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos