Skip to content

Do not automatically create pip-tools pull requests on forks of this repo #11738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 3, 2024

Currently, this GitHub Action creates new pull requests on the forks of all contributors. Let's make sure that the job only creates pull requests

if: github.repository_owner == 'readthedocs'

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context

Currently, this GitHub Action runs on the forks of all contributors.  Let's make sure that it is only run when the `github.repository_owner == readthedocs`

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context
@cclauss cclauss requested a review from a team as a code owner November 3, 2024 07:02
@cclauss cclauss requested a review from humitos November 3, 2024 07:02
@cclauss cclauss changed the title Do not the pip-tools.yaml cron job on forks of this repo Do not run the pip-tools.yaml cron job on forks of this repo Nov 3, 2024
@cclauss cclauss changed the title Do not run the pip-tools.yaml cron job on forks of this repo Do not run cron job pip-tools.yaml on forks of this repo Nov 3, 2024
@cclauss cclauss changed the title Do not run cron job pip-tools.yaml on forks of this repo Do not automatically create pip-tools pull requests on forks of this repo Nov 3, 2024
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible to put the condition at job level instead? That way, the whole job is skipped on forks.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 4, 2024

Yes. The first commit did that but the second commit took a more targeted approach. I will move the if back to global scope.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 4, 2024

Is there a fix for the failing tests-ext-theme?

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@humitos
Copy link
Member

humitos commented Nov 4, 2024

Is there a fix for the failing tests-ext-theme?

Nope, but no need to worry about it for now.

@humitos
Copy link
Member

humitos commented Nov 4, 2024

Thanks!

@humitos humitos merged commit 7198d3d into readthedocs:main Nov 4, 2024
1 of 5 checks passed
@cclauss cclauss deleted the patch-3 branch November 4, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants