Addons: default to semver for sorting versions #11686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
default-to-semver
branch
from
94ae5f2 to
a165e4c
Compare
humitos
approved these changes
Oct 15, 2024
| choices=ADDONS_FLYOUT_SORTING_CHOICES, | ||
| default=ADDONS_FLYOUT_SORTING_ALPHABETICALLY, | ||
| default=ADDONS_FLYOUT_SORTING_SEMVER_READTHEDOCS_COMPATIBLE, |
There was a problem hiding this comment.
This won't update existing projects, right? I wonder if we should migrate it for them 🤔
There was a problem hiding this comment.
Yeah, not sure if we have a good way to tell apart users that set this option explicitly and who didn't (maybe check if created and modified are equal?)
stsewd
force-pushed
the
default-to-semver
branch
from
4b1dcbc to
6c4e155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the verbose names, since it was using the name of the fields by default, which aren't great to show to users.
Before
Now