fix proxito header #11680
Merged
fix proxito header #11680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericholscher
commented
Oct 15, 2024
ericholscher
commented
- Fix Content type on addons in dev
- Keep caching
humitos
approved these changes
Oct 15, 2024
Comment on lines
+27
to
28
| proxy_hide_header Content-Type; | ||
| add_header Content-Type "text/javascript; charset=utf-8" always; |
There was a problem hiding this comment.
I remember having a similar issue with this, that's why I was forcing the content-type with add_header. I don't understand why it's not overwriting it since it's being forced here 🤷🏼
There was a problem hiding this comment.
I think GH started adding a content type, and ours was getting appended, instead of replacing it.
|
@ericholscher we should do the same on commercial 😉 |
ericholscher
added a commit
that referenced
this pull request
Oct 15, 2024
ericholscher
added a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.