Prefetch build and project on version list #11616
Conversation
This optimizes the version listing view and removes redundant queries. - Requires readthedocs/ext-theme#493 - Fixes readthedocs/ext-theme#463
| if hasattr(self, self.LATEST_BUILD_CACHE): | ||
| if latest_build := getattr(self, self.LATEST_BUILD_CACHE): |
There was a problem hiding this comment.
I don't think we need the first if here?
There was a problem hiding this comment.
I started to write it like that but we do need to test for hasattr first, as this attribute only exists after prefetch and it's what shortcuts this method to avoid the return self.builds.... below.
If this was just getattr, we'd always skip the return self.builds... below.
| @@ -141,6 +141,30 @@ def for_reindex(self): | |||
| .distinct() | |||
| ) | |||
|
|
|||
| def prefetch_subquery(self): | |||
There was a problem hiding this comment.
Why don't we call it prefetch_latest_build() instead to keep consistency to what we are doing with Project at https://github.com/readthedocs/readthedocs.org/pull/11613/files#diff-05611882195df182851df952b312f031a4314bce04a104e10a09655e570515f3R124?
There was a problem hiding this comment.
That method shouldn't be called prefetch_latest_build, it's doing more than that. Similar here, there are other fields to prefetch.
|
I'm going to merge it so it goes out in today's deploy, but there are some comments that need to be addressed. |
This reverts commit e5f8092.
This reverts commit e5f8092.
This optimizes the version listing view and removes redundant queries.