Skip to content

Slack: use json= to send a message using webhooks #11536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 12, 2024

It was giving us 400 because we weren't sending the data as JSON.
I also add a small log line, just in case.

It was giving us 400 because we weren't sending the data as JSON.
I also add a small log line, just in case.
@humitos humitos requested a review from a team as a code owner August 12, 2024 18:05
@humitos humitos requested a review from stsewd August 12, 2024 18:05
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really have tests for this

@humitos humitos merged commit 6036c2e into main Aug 14, 2024
6 checks passed
@humitos humitos deleted the humitos/slack-message-json branch August 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants