-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Project: allow connecting a project to a remote repository after it has been created #11498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yep, I'll change the text of the default empty selection. |
It might also be worth using something like "Connected repository" instead of "Remote repository" in the user UI, to give a stronger framing to the user about the purpose of the field -- "remote repository" doesn't quite do this. @stsewd Do the view changes affect the project creation views on either dashboard at all? I'm having trouble figuring this out by looking at the code. |
Nope, that input is still hidden from the creation form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more notes. I think this is looking really good, I had a couple other comments on the PR that might change this a little bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
After this as a first pass, I think we'll eventually want a polish pass on this that adds some more UI or maybe just moves the form view too. This is mostly to add a modal warning or something "Hey, don't change this if you're not sure exactly what this is doing".
But also, we talked about making this a nice UI too, so perhaps that's all one project and it all belongs in a dedicated admin UI.
Is it possible to make the field searchable in the new dashboard? (similar to what we do at "Add project"). Users with a lot of repositories will have issues finding the correct one. |
It's searchable |
Closes #9437