Skip to content

Add Unknown for missing VCS class #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 11, 2024
Merged

Add Unknown for missing VCS class #11398

merged 4 commits into from
Jun 11, 2024

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher requested a review from a team as a code owner June 11, 2024 15:42
@ericholscher ericholscher requested a review from humitos June 11, 2024 15:42
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jun 11, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: readthedocs/projects/models.py

Function Unhandled Issue
get_default_branch AttributeError: 'NoneType' object has no attribute 'fallback_branch' /_...
Event Count: 9
get_default_branch AttributeError: 'NoneType' object has no attribute 'fallback_branch' /proj...
Event Count: 9

Did you find this useful? React with a 👍 or 👎

@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Jun 11, 2024
humitos
humitos approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it already solves the problem in production.

@ericholscher ericholscher enabled auto-merge (squash) June 11, 2024 16:40
@ericholscher ericholscher merged commit bf28567 into main Jun 11, 2024
4 of 5 checks passed
@ericholscher ericholscher deleted the unknown-default-branch branch June 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@ericholscher ericholscher

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos