-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update allauth #11327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update allauth #11327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here seem minimal, but I cannot speak as to the issues with 0.58.0. I would get @humitos opinion here.
I did raise in the ext-theme PR whether or not the template changes have any other affect on our templates. How much did the previous base.html
template deviate from the new base_entrance.html
?
@agjohnson all UI elements look the same to me, for what I can tell the re-organization was made in order to be able to re-use the base template across all views. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏼
I'm blocking releasing this today due to readthedocs/ext-theme#350 that hasn't been approved yet and it seems there is a bug to fix yet. We can release it next week, since it shouldn't take too much to create the fix. |
0.63 is the latest release, but pip-tools doesn't seem to recognize the SAML deps, probably a bug with the package (also, the last version is quiet recent), so better to stick to 0.61 for now.Fixed, we are using the latest version now.Changes are small, the templates changes were mostly to move the base override to another file. The old bitbucket integration was also removed (we would still have integrations in the db, see #11162).
URLs for listing the social accounts have changed, but they added redirects for them.
Closes #11309