Skip to content

Dashboard: promote features in the right bar #11287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 17, 2024

Small logic to decide which feature to promote.
This is pretty simple for now, but it shows the pattern we are thinking about.

Required by readthedocs/ext-theme#103

Small logic to decide which feature to promote.
This is pretty simple for now, but it shows the pattern we are thinking about.

Required by readthedocs/ext-theme#103
@humitos humitos requested a review from agjohnson April 18, 2024 09:57
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I know we'll come back to this and tune it, and would like to revisit it fairly often. I do see new users into an organization getting the security logs block initially, so the fallback is probably the first thing to change next.

I could also see us eventually matching new user onboarding content with our drip email content, and then going into this logic. All of this is good for next additions here though.

@humitos humitos merged commit 3912b7d into main Apr 22, 2024
7 checks passed
@humitos humitos deleted the humitos/show-dashboard-promotion branch April 22, 2024 18:14
Copy link

sentry-io bot commented Apr 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ UnboundLocalError: local variable 'template_name' referenced before assignment /dashboard/ View Issue
  • ‼️ AttributeError: 'NoneType' object has no attribute 'pub_date' /dashboard/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants