Skip to content

Allow override SOCIALACCOUNT_PROVIDERS from ops #11165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Allow override SOCIALACCOUNT_PROVIDERS from ops #11165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366889c
Allow override SOCIALACCOUNT_PROVIDERS from ops
stsewd Feb 27, 2024
04210a9
Property
stsewd Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion readthedocs/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ def DOCKER_LIMITS(self):
SOCIALACCOUNT_AUTO_SIGNUP = False
SOCIALACCOUNT_STORE_TOKENS = True

SOCIALACCOUNT_PROVIDERS = {
_SOCIALACCOUNT_PROVIDERS = {
'github': {
"APPS": [
{
Expand Down Expand Up @@ -696,6 +696,16 @@ def DOCKER_LIMITS(self):
],
},
}

@property
def SOCIALACCOUNT_PROVIDERS(self):
"""
This is useful to override in a subclass, mainly to add the secrets when deploying.

Our ops repos have a complex (shared) inheritance structure, so it's easier this way.
"""
return self._SOCIALACCOUNT_PROVIDERS

ACCOUNT_FORMS = {
'signup': 'readthedocs.forms.SignupFormWithNewsletter',
}
Expand Down