Custom domain: don't allow external domain #11064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a CNAME from our external domain to readthedocs.io, making these domains valid if they are added to a project.
This isn't a security issue, since our code won't resolve those domains because custom domains are checked last, and we have this protection in place:
readthedocs.org/readthedocs/core/unresolver.py
Lines 590 to 594 in 7daff3d