Config: allow missing conda.environment when using build.commands
#11040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
approved these changes
Jan 17, 2024
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubecore
that referenced
this pull request
Feb 5, 2024
Use the `--yes` flag of `mamba env create` in case environment exists. Skip `poetry run` when running `sphinx-build` since Poetry installs in the conda environment directly. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubecore
that referenced
this pull request
Feb 5, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Skip `poetry run` when running `sphinx-build` since Poetry installs in the conda environment directly. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
fabcor-maxiv
added a commit
to mxcube/mxcubecore
that referenced
this pull request
Feb 5, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Skip `poetry run` when running `sphinx-build` since Poetry installs in the conda environment directly. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubeweb
that referenced
this pull request
Feb 7, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
fabcor-maxiv
added a commit
to fabcor-maxiv/mxcubeweb
that referenced
this pull request
Feb 7, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
marcus-oscarsson
pushed a commit
to mxcube/mxcubeweb
that referenced
this pull request
Feb 7, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
HilbertCorsair
pushed a commit
to HilbertCorsair/mxcubecore_SOLEIL_PX1
that referenced
this pull request
Feb 23, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Skip `poetry run` when running `sphinx-build` since Poetry installs in the conda environment directly. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
walesch-yan
pushed a commit
to mxcube/mxcubecore
that referenced
this pull request
Jun 17, 2024
Use the `--force` flag of `mamba env create` in case environment exists. Skip `poetry run` when running `sphinx-build` since Poetry installs in the conda environment directly. Remove the workaround for the unwarranted error about "missing `conda.environment`" configuration setting, because it has been fixed already. See: * readthedocs/readthedocs.org#10979 (comment) * readthedocs/readthedocs.org#11040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #10979 (comment)