Skip to content

Build: typo on on_retry #11014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2024
Merged

Build: typo on on_retry #11014

merged 2 commits into from
Jan 10, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 9, 2024

@humitos humitos requested a review from a team as a code owner January 9, 2024 16:44
@humitos humitos requested a review from stsewd January 9, 2024 16:44
@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Jan 9, 2024
stsewd
stsewd approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably a missing test that should have caught this

@humitos
Copy link
Member Author

humitos commented Jan 10, 2024

Yeah, our build process is not fully tested. There are some cases, like this one that needs a Retry that's not easy to write a test for.

@humitos humitos enabled auto-merge (squash) January 10, 2024 16:03
@humitos humitos merged commit 3fee5e8 into main Jan 10, 2024
@humitos humitos deleted the humitos/on-retry-fix branch January 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees

@humitos humitos

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @stsewd