Resolver: use new methods to resolve documentation pages #10875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Oct 27, 2023
| @@ -912,14 +912,15 @@ def changefreqs_generator(): | |||
|
|
|||
| if project.translations.exists(): | |||
| for translation in project.translations.all(): | |||
| translation_versions = ( | |||
There was a problem hiding this comment.
We were fetching all versions from the translation, when we just need to get a version matching the same slug as the current version.
ericholscher
approved these changes
Oct 27, 2023
| @@ -135,12 +134,10 @@ def get(self, request): | |||
| def do_embed(*, project, version, doc=None, path=None, section=None, url=None): | |||
| """Get the embed response from a document section.""" | |||
| if not url: | |||
| external = version.type == EXTERNAL | |||
There was a problem hiding this comment.
Do we not need this anymore?
There was a problem hiding this comment.
We get the type of the version from the version object itself
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may result in one queryset less in some cases, others will remain the same.