Skip to content

Tests: Update Sphinx test matrix for EmbedAPI #10655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 22, 2023

  • Test only the latest minor version of each major version
  • Add newer versions we weren't testing

- Test only the latest minor version of each major version
- Add newer versions we weren't testing
@humitos humitos requested a review from a team as a code owner August 22, 2023 20:40
@humitos humitos requested a review from stsewd August 22, 2023 20:40
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... Also 👍 on removing support for old versions of Sphinx, if we want. But probably a larger discussion.

@humitos
Copy link
Member Author

humitos commented Aug 22, 2023

I updated the PR with some changes:

  • do not run migrations when testing EmbedAPI
  • fix tests for Sphinx 7.x

@humitos humitos merged commit 751fc99 into main Aug 22, 2023
@humitos humitos deleted the humitos/embed-api-tests branch August 22, 2023 21:55
@humitos
Copy link
Member Author

humitos commented Aug 22, 2023

We went down from ~40m to 9m when running EmbedAPI tests 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants