-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Black: run black over all the code base #10619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
``` gh pr list --json number -L 100 | jq '.[].number' | xargs -I{} gh pr view {} --json files --jq '.files.[].path' | sort | uniq > pr-files.txt git ls-files | grep -v -f pr-files.txt | grep '.py$' | xargs black ``` Reference: * readthedocs/meta#30 (reply in thread)
Once this PR gets merged, we need to open a new one to ignore these commits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're all agreed on this path forward, so let's get it merged 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing particularly interesting that I saw. Looks good to go 👍
🚀 |
@humitos we should also do the same for commercial 👍 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Continues with the idea started in #10619
Continues with the idea started in #10619
If you want to review some changes, these are the ones I've done manually to fix prospector lint issues: 4d3809b
Reference:
📚 Documentation previews 📚
docs
): https://docs--10619.org.readthedocs.build/en/10619/dev
): https://dev--10619.org.readthedocs.build/en/10619/