Skip to content

Black: run black over all the code base #10619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 9, 2023

gh pr list --json number -L 100 | jq '.[].number' | xargs -I{} gh pr view {} --json files --jq '.files.[].path' | sort | uniq > pr-files.txt
git ls-files | grep -v -f pr-files.txt | grep '.py$' | xargs black

If you want to review some changes, these are the ones I've done manually to fix prospector lint issues: 4d3809b

Reference:

  • readthedocs/meta#30 (reply in thread)

📚 Documentation previews 📚

humitos added 3 commits August 9, 2023 12:05
```
gh pr list --json number -L 100 | jq '.[].number' | xargs -I{} gh pr view {} --json files --jq '.files.[].path' | sort | uniq > pr-files.txt
git ls-files | grep -v -f pr-files.txt | grep '.py$' | xargs black
```

Reference:

* readthedocs/meta#30 (reply in thread)
@humitos humitos requested review from a team as code owners August 9, 2023 10:10
@humitos humitos requested a review from ericholscher August 9, 2023 10:10
@humitos
Copy link
Member Author

humitos commented Aug 9, 2023

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're all agreed on this path forward, so let's get it merged 💯

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing particularly interesting that I saw. Looks good to go 👍

@humitos
Copy link
Member Author

humitos commented Aug 9, 2023

🚀

@humitos humitos merged commit 8cae85b into main Aug 9, 2023
@humitos humitos deleted the humitos/black-code-base branch August 9, 2023 15:52
@ericholscher
Copy link
Member

@humitos we should also do the same for commercial 👍

@sentry-io
Copy link

sentry-io bot commented Aug 10, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ConnectionError: HTTPSConnectionPool(host='www.google-analytics.com', port=443): Max retries exceeded with url: /c... readthedocs.analytics.tasks.analytics_event View Issue
  • ‼️ ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) readthedocs.analytics.tasks.analytics_event View Issue
  • ‼️ ConnectionError: HTTPSConnectionPool(host='www.google-analytics.com', port=443): Max retries exceeded with url: /c... readthedocs.analytics.tasks.analytics_event View Issue
  • ‼️ SSLError: HTTPSConnectionPool(host='www.google-analytics.com', port=443): Max retries exceeded with url: /c... readthedocs.analytics.tasks.analytics_event View Issue
  • ‼️ ConnectionError: HTTPSConnectionPool(host='web-1390472897.us-east-2.elb.amazonaws.com', port=443): Max retries exc... readthedocs.projects.tasks.builds.update_docs_task View Issue

Did you find this useful? React with a 👍 or 👎

humitos added a commit that referenced this pull request Jan 9, 2024
Continues with the idea started in
#10619
humitos added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants