Skip to content

Add USE_ORGANIZATIONS context variablea #10592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Conversation

agjohnson
Copy link
Contributor

This copies USE_SUBDOMAIN and USE_PROMOS pattern for use in the templates when
adding features for organizations/commercial. This would supersede checks like
PRODUCTION_DOMAIN == "readthedocs.com" and friends.

@agjohnson agjohnson requested a review from a team as a code owner August 2, 2023 00:52
@agjohnson agjohnson requested a review from humitos August 2, 2023 00:52
@agjohnson
Copy link
Contributor Author

Docs test failure is unrelated, looks like an intersphinx page moved.

There were some tests I need to update around the context variable though.

@stsewd
Copy link
Member

stsewd commented Aug 2, 2023

@agjohnson doc failure is already fixed in main, there is another test that needs fixing #10597

@agjohnson
Copy link
Contributor Author

Thanks for the info @stsewd ! I'll leave the doc failure here then, as I don't want to merge in a test failure to this branch as well.

I updated the tests again, hopefully this is enough for my single line change PR 🙃

I got frustrated and just ran black on all of the test file, 87a8a85 is just some minor changes.

@agjohnson agjohnson requested a review from humitos August 2, 2023 22:21
@agjohnson agjohnson merged commit 689e5c6 into main Aug 2, 2023
@agjohnson agjohnson deleted the agj/add-organization-context branch August 2, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants