Add redirect to about.readthedocs.com for logged out users
#10570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last step in our migration to a new marketing page, showing it to logged out users on readthedocs.org. Currently logged in users will hit a homepage at the root, but this change makes that page redirect to the dashboard for community users.
stsewd
approved these changes
Jul 25, 2023
agjohnson
approved these changes
Jul 26, 2023
|
|
||
| # Redirect to ``about.`` in production | ||
| if not settings.DEBUG: | ||
| query_string = "?ref=dotorg-homepage" |
There was a problem hiding this comment.
I'm guessing we don't use this view on the commercial application, as we are already adding this to the requests on commercial. But if we do, this query string could be conditional based on the application instance.
There was a problem hiding this comment.
Yea, we're overriding it. Could probably stop now though, if we wanted 🤔
|
@stsewd I expanded the logic removal here, so could use another review 👍 |
stsewd
approved these changes
Jul 26, 2023
|
Not going to merge this until we're 100% sure we're ready with the marketing website. Might hold off a week or two, but good to have it ready 👍 |
ericholscher
added
Status: blocked
|
Our latest deploy is now out, so going to merge this so it's ready for next week 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step in our migration to a new marketing page,
showing it to logged out users on readthedocs.org.
Currently logged in users will hit a homepage at the root,
but this change makes that page redirect to the dashboard for community users.
Fixes #10571