MkDocs: fix USE_MKDOCS_LATEST feature flag logic
#10515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic was inverted and we were installing old MkDocs version to projects with `USE_MKDOCS_LATEST` feature flag. Closes #10402
stsewd
approved these changes
Jul 6, 2023
ericholscher
reviewed
Jul 6, 2023
This is not required anymore since the logic was inverted and we were installing always the latest version for old projects, but the old version for new projects. It's better to have all of them installing the latest version and call it a day :)
ericholscher
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was inverted and we were installing old MkDocs version to projects with
USE_MKDOCS_LATESTfeature flag.Closes #10402