Builds: set scale-in protection before/after each build #10507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use AWS scale-in protection to protect our instances from being scaled-in automatically while running a build. This avoids killing the build in the middle while it's running. Besides, it could help us to be more aggressive to scale-in if we consider without degrading user experience. Related readthedocs/readthedocs-ops#1324
stsewd
reviewed
Jul 5, 2023
agjohnson
reviewed
Jul 5, 2023
There was a problem hiding this comment.
The change here is looking good, though I might hesitate to turn this on for all projects all at once. If feature flag is too much, we can always test this with a partial deploy or something, but I suspect we might want to leave this on for a while to test this all works as expected.
Co-authored-by: Anthony <[email protected]>
This way we will be able to have more control and enable/disable this without requiring a deploy in case that something goes wrong.
|
I put the scale-in protection under a feature flag. It's ready for re-review. |
agjohnson
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use AWS scale-in protection to protect our instances from being scaled-in automatically while running a build. This avoids killing the build in the middle while it's running.
Besides, it could help us to be more aggressive to scale-in if we consider without degrading user experience.
Related https://github.com/readthedocs/readthedocs-ops/issues/1324
Requires: https://github.com/readthedocs/readthedocs-ops/pull/1356