Skip to content

Reduce logging of common redirects and expected items #10497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 28, 2023

This should massively reduce the amount of logs we're showing:
@ericholscher ericholscher requested a review from a team as a code owner June 28, 2023 17:33
@ericholscher ericholscher requested a review from stsewd June 28, 2023 17:33
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linting problems that need to be fixed

@ericholscher
Copy link
Member Author

readthedocs/common#180

@humitos
Copy link
Member

humitos commented Jun 29, 2023

I don't know where that "Log event" UI you showed in the description comes from, but I just wanted to comment here that I usually use the "Log Patterns" one: https://one.newrelic.com/logger/log-patterns?account=63767&duration=604800000&state=bfbf16ba-d4d1-b557-f420-a41585d0530b and has been being really useful to me.

@ericholscher
Copy link
Member Author

@humitos nice, that's a good dashboard. Mine was just a custom query that I futzed with in NR -- I figured it was built in, but couldn't find it quickly :)

@ericholscher ericholscher merged commit 1b32d18 into main Jun 29, 2023
@ericholscher ericholscher deleted the lower-redirect-logging branch June 29, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants