Skip to content

Requirements: upgrade all requirements #10482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 27, 2023

The GitHub Action has been failing lately. So, I ran pip-tools manually and I'm opening a PR hoping all the tests to pass. Otherwise, we can investigate if needed.

The GitHub Action has been failing lately. So, I run pip-tools manually and I'm
opening a PR hoping all the tests to pass. Otherwise, we can investigate if needed.
@humitos
Copy link
Member Author

humitos commented Jun 27, 2023

This is the test that fails: TestBuildTaskExceptionHandler.test_config_file_exception

It fails because we are mocking a function and using side_effect raising an exception at

@mock.patch("readthedocs.doc_builder.director.load_yaml_config")
def test_config_file_exception(self, load_yaml_config):
load_yaml_config.side_effect = ConfigError(
code="invalid", message="Invalid version in config file."
)

@stsewd
Copy link
Member

stsewd commented Jul 5, 2023

This was done in #10503.

@stsewd stsewd closed this Jul 5, 2023
@stsewd stsewd deleted the humitos/pip-requirements-upgrade branch July 5, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants