Proxito: improve query to check for addons #10458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Jun 22, 2023
humitos
added a commit
that referenced
this pull request
Jun 22, 2023
We don't need the `Project` instance. We were using to check for a Feature flag, but now we are only adding the header when the project is using `build.commands`. If we ever require the `Project` instance again, we can do a `.select_related` from the `Version` object. That way, we still keep doing 1 query only. Closes #10458 Related #10456
|
I found a different solution that removes 1 query. It doesn't query the |
humitos
added a commit
that referenced
this pull request
Jun 22, 2023
) We don't need the `Project` instance. We were using to check for a Feature flag, but now we are only adding the header when the project is using `build.commands`. If we ever require the `Project` instance again, we can do a `.select_related` from the `Version` object. That way, we still keep doing 1 query only. Closes #10458 Related #10456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement until we work on #10456