API V3: add IsAuthenticated to permissions #10452
Merged
+250
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't a security vulnerability, we were filtering by the current user. This was just causing errors, since we were expecting a real user in some queries. These views are used in .com only, so I have added tests there. Ref https://read-the-docs.sentry.io/issues/4261898141/?alert_rule_id=242443&alert_timestamp=1687234764178&alert_type=email&environment=production&project=161479&referrer=alert_email
benjaoming
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
The change itself looks good, and great to have tests validating this as well 👏
The tests seem to follow the same logic:
Given a URL name, kwargs, an HTTP method and optional post data, check that the expected response codes are returned: a) when not logged in and b) when logged in.
So I guess that could also be in some utility method :) I think that'd be nice to maybe note for anyone working on the test code in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a security vulnerability,
we were filtering by the current user.
This was just causing errors, since we were expecting a real user in some queries.
These views are used in .com only, so I have added tests there.
Also, went ahead and added tests for all other endpoints that didn't have them.
Ref https://read-the-docs.sentry.io/issues/4261898141/?alert_rule_id=242443&alert_timestamp=1687234764178&alert_type=email&environment=production&project=161479&referrer=alert_email