Skip to content

Dependencies: all packages updated via pip-tools #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Dependencies: all packages updated via pip-tools

@github-actions github-actions bot requested a review from a team as a code owner June 18, 2023 00:07
@github-actions github-actions bot requested a review from benjaoming June 18, 2023 00:07
@humitos
Copy link
Member

humitos commented Jun 18, 2023

1 test is failing. It seems the exception risen cannot be pickled for some reason

@benjaoming benjaoming added the Status: blocked Issue is blocked on another issue label Jun 19, 2023
@benjaoming
Copy link
Contributor

Ah yeah, getting the generic BuildAppError instead of ConfigError. It's probably the celery upgrade.

There is a 5.3.1 release out. So worth testing that instead.

Otherwise, also worth holding back. This release has way more changes than what we can quickly read through.

https://docs.celeryq.dev/en/stable/changelog.html

@humitos
Copy link
Member

humitos commented Jun 19, 2023

Good point. I'm closing this PR. Next week we will have a new one with the latest updates 👍🏼

@humitos humitos closed this Jun 19, 2023
@benjaoming
Copy link
Contributor

Noting for next week: I had the same issue with celery 5.3.1, so not worth looking into until there's another release out. There's nothing indicating that this very very simple Exception should cause this particular issue... unless somehow mocking stuff makes it impossible to pickle.

@stsewd stsewd deleted the dependencies/pip-tools-187e698 branch June 19, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: blocked Issue is blocked on another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants