Celery: increase frequency of delete_closed_external_versions task
#10425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have 255k versions that should have been deleted already, but we are executing the task with a limit of 200 version. This makes the task to not catch up with all the versions that has to delete, and we keep accumulating them. This commit increases the frequency from "once a day" to "every 3 hours". It will help to catch up and to keep our database clean of closed PRs. Related readthedocs/readthedocs-ops#1291
stsewd
approved these changes
Jun 13, 2023
Co-authored-by: Santos Gallegos <[email protected]>
|
I checked this today: we have 258k versions from readthedocs.builds.constants import (
EXTERNAL_VERSION_STATE_CLOSED,
)
days_ago = timezone.now() - timezone.timedelta(days=days)
queryset = Version.external.filter(
state=EXTERNAL_VERSION_STATE_CLOSED,
modified__lte=days_ago,
)
queryset.count() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 255k versions that should have been deleted already, but we are executing the task with a limit of 200 version. This makes the task to not catch up with all the versions that has to delete, and we keep accumulating them.
This commit increases the frequency from "once a day" to "every 3 hours". It will help to catch up and to keep our database clean of closed PRs.
Related https://github.com/readthedocs/readthedocs-ops/issues/1291