Skip to content

Docs: Add $READTHEDOCS_OUTPUT to environment variable reference #10407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2023
Merged

Docs: Add $READTHEDOCS_OUTPUT to environment variable reference #10407

merged 3 commits into from
Jun 9, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jun 7, 2023 •
edited
Loading

Seems like we forgot this one :)

Refs: #9913

📚 Documentation previews 📚

@benjaoming benjaoming requested a review from humitos June 7, 2023 19:55
@benjaoming benjaoming requested a review from a team as a code owner June 7, 2023 19:55
@benjaoming benjaoming requested a review from ericholscher June 7, 2023 19:55
@benjaoming benjaoming added the Improvement Minor improvement to code label Jun 7, 2023
humitos
humitos reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. Happy to have this variable documented. There is a mistake in the explanation that we should fix before merging

humitos
humitos reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More feedback that I just noticed 😄

@benjaoming benjaoming requested a review from humitos June 9, 2023 11:23
@benjaoming benjaoming merged commit e32efc0 into main Jun 9, 2023
@benjaoming benjaoming deleted the docs/READTHEDOCS_OUTPUT branch June 9, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@ericholscher ericholscher Awaiting requested review from ericholscher ericholscher is a code owner automatically assigned from readthedocs/advocacy

Assignees

@benjaoming benjaoming

Labels
Improvement Minor improvement to code
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaoming @humitos